Fix(git_fetcher): cleanup repo dir on clone failure#873
Closed
Dulifu0 wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for opal-docs canceled.
|
7 tasks
Contributor
|
Thank you for taking the time to put this together. We're closing this PR because the linked issue #634 has been closed as a stale bounty, and the maintainers have stated they don't plan to pursue a fix for it at this time. A couple of additional notes for transparency: this PR also competes with several other open PRs targeting the same issue (#845, #864, #875, #880, #881), and it bundles an unrelated dependency change (removing the upper bound on the pygit2 pin in requires.txt) that is out of scope for a clone-cleanup fix. We really appreciate the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #634