Skip to content

Fix(git_fetcher): cleanup repo dir on clone failure #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dulifu0 wants to merge 1 commit into from
Closed

Fix(git_fetcher): cleanup repo dir on clone failure #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/opal-server/opal_server/git_fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,10 @@ async def _clone(self):
)
except pygit2.GitError:
logger.exception(f"Could not clone repo at {self._source.url}")
# Fix: Cleanup failed clone directly to prevent "directory not empty" or symlink leftovers
if self._repo_path.exists():
logger.warning(f"Cleaning up failed clone directory: {self._repo_path}")
shutil.rmtree(self._repo_path)
else:
logger.info(f"Clone completed: {self._source.url}")
await self._notify_on_changes(repo)
Expand Down
2 changes: 1 addition & 1 deletion packages/opal-server/requires.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ gitpython>=3.1.32,<4
pyjwt[crypto]>=2.1.0,<3
slowapi>=0.1.5,<1
# slowapi is stuck on and old `redis`, so fix that and switch from aioredis to redis
pygit2>=1.14.1,<1.15
pygit2>=1.14.1
asgiref>=3.5.2,<4
redis>=4.3.4,<5