fix(env): VITE_* env vars are strings, not numbers or booleans - #689
Open
2xburnt wants to merge 1 commit into
Open
fix(env): VITE_* env vars are strings, not numbers or booleans#6892xburnt wants to merge 1 commit into
2xburnt wants to merge 1 commit into
Conversation
Vite injects env vars as strings regardless of what the .env file contains, but env.d.ts declared three of them as number/boolean. That mistyping hid a real bug: const FETCH_ALL_BLOCKS = import.meta.env.VITE_FETCH_ALL_BLOCKS || false; `VITE_FETCH_ALL_BLOCKS=false` yields the string "false", which is truthy, so the documented way to turn the feature off in .env.example silently turns it on - and it then fetches every intermediate block, which is exactly the rate-limiting the flag exists to avoid. Corrects the declared types, compares explicitly against 'true', and coerces the two numeric vars so they reach setInterval and slice as numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite injects env vars as strings regardless of what the .env file contains, but env.d.ts declared three of them as number/boolean. That mistyping hid a real bug:
const FETCH_ALL_BLOCKS = import.meta.env.VITE_FETCH_ALL_BLOCKS || false;
VITE_FETCH_ALL_BLOCKS=falseyields the string "false", which is truthy, so the documented way to turn the feature off in .env.example silently turns it on - and it then fetches every intermediate block, which is exactly the rate-limiting the flag exists to avoid.Corrects the declared types, compares explicitly against 'true', and coerces the two numeric vars so they reach setInterval and slice as numbers.