Skip to content

fix(env): VITE_* env vars are strings, not numbers or booleans #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2xburnt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(env): VITE_* env vars are strings, not numbers or booleans #689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
/// <reference types="vite/client" />

declare module '@personaxyz/ad-sdk';
// Vite injects env vars as strings whatever the .env file looks like. Declaring
// them as number/boolean hides bugs such as `"false"` being truthy.
interface ImportMetaEnv {
readonly VITE_REFRESH_INTERVAL?: number,
readonly VITE_FETCH_ALL_BLOCKS?: boolean,
readonly VITE_RECENT_BLOCK_LIMIT?: number,
readonly VITE_REFRESH_INTERVAL?: string,
readonly VITE_FETCH_ALL_BLOCKS?: string,
readonly VITE_RECENT_BLOCK_LIMIT?: string,
readonly VITE_COINGECKO_URL?: string,
readonly VITE_GITHUB_API_URL?: string,
readonly VITE_PINGPUB_API_URL?: string,
Expand Down
2 changes: 1 addition & 1 deletion src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { onMounted, onUnmounted, ref } from 'vue';
import TxDialog from './components/TxDialog.vue';
import { useBaseStore } from '@/stores';

const REFRESH_INTERVAL = import.meta.env.VITE_REFRESH_INTERVAL || 6000;
const REFRESH_INTERVAL = Number(import.meta.env.VITE_REFRESH_INTERVAL) || 6000;

const blockStore = useBaseStore();
const requestCounter = ref(0);
Expand Down
5 changes: 3 additions & 2 deletions src/stores/useBaseStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ import type { Block } from '@/types';
import { hashTx } from '@/libs';
import { fromBase64 } from '@cosmjs/encoding';

const FETCH_ALL_BLOCKS = import.meta.env.VITE_FETCH_ALL_BLOCKS || false;
const RECENT_BLOCKS_LIMIT = import.meta.env.VITE_RECENT_BLOCK_LIMIT || 50;
// `"false"` is a truthy string, so compare explicitly.
const FETCH_ALL_BLOCKS = import.meta.env.VITE_FETCH_ALL_BLOCKS === 'true';
const RECENT_BLOCKS_LIMIT = Number(import.meta.env.VITE_RECENT_BLOCK_LIMIT) || 50;

export const useBaseStore = defineStore('baseStore', {
state: () => {
Expand Down
Loading