[Multi_K8s-Plugin] rename stages to avoid conflicts with kubernetes plugin#6880
Merged
Warashi merged 2 commits intoMay 30, 2026
Merged
Conversation
…lugin Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
mohammedfirdouss
force-pushed
the
feat/multicluster-stage-rename
branch
from
3e53228 to
214023f
Compare
Contributor
Author
|
@Warashi check here, thanks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6880 +/- ##
==========================================
- Coverage 29.37% 29.36% -0.01%
==========================================
Files 601 601
Lines 64282 64282
==========================================
- Hits 18883 18879 -4
- Misses 43931 43934 +3
- Partials 1468 1469 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thank you for contributing to PipeCD! The changes in this pull request will be part of the upcoming release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: Renames the Kubernetes multicluster plugin stage names to include a
MULTI_prefix, avoiding collisions with the regular Kubernetes plugin stage names.Why we need it: A Piped instance cannot have two plugins registering the same stage name. The multicluster plugin previously used identical names to the Kubernetes plugin (
K8S_PRIMARY_ROLLOUT,K8S_CANARY_ROLLOUT, etc.), which would cause routing conflicts when both plugins are loaded.The following stages are renamed:
K8S_PRIMARY_ROLLOUT→K8S_MULTI_PRIMARY_ROLLOUTK8S_CANARY_ROLLOUT→K8S_MULTI_CANARY_ROLLOUTK8S_CANARY_CLEAN→K8S_MULTI_CANARY_CLEANK8S_BASELINE_ROLLOUT→K8S_MULTI_BASELINE_ROLLOUTK8S_BASELINE_CLEAN→K8S_MULTI_BASELINE_CLEANK8S_TRAFFIC_ROUTING→K8S_MULTI_TRAFFIC_ROUTINGWhich issue(s) this PR fixes: Fixes #
Does this PR introduce a user-facing change?:
app.pipecd.yamlpipeline stage names to use the newK8S_MULTI_*prefixed names.app.pipecd.yamlfiles that use the Kubernetes multicluster plugin.