Skip to content

[Multi_K8s-Plugin] rename stages to avoid conflicts with kubernetes plugin #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Warashi merged 2 commits into from
May 30, 2026
+12 −12
Merged

[Multi_K8s-Plugin] rename stages to avoid conflicts with kubernetes plugin #6880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
214023f
[Multi_K8s-Plugin] rename stages to avoid conflicts with kubernetes p…
mohammedfirdouss May 29, 2026
ed33f3f
Merge branch 'master' into feat/multicluster-stage-rename
mohammedfirdouss May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pkg/app/pipedv1/plugin/kubernetes_multicluster/deployment/canary_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ func TestPlugin_executeK8sMultiCanaryCleanStage(t *testing.T) {

input := &sdk.ExecuteStageInput[kubeconfig.KubernetesApplicationSpec]{
Request: sdk.ExecuteStageRequest[kubeconfig.KubernetesApplicationSpec]{
StageName: "K8S_CANARY_CLEAN",
StageName: "K8S_MULTI_CANARY_CLEAN",
StageConfig: []byte(`{}`),
TargetDeploymentSource: sdk.DeploymentSource[kubeconfig.KubernetesApplicationSpec]{
ApplicationDirectory: filepath.Join("testdata", "simple"),
Expand Down Expand Up @@ -446,7 +446,7 @@ func TestPlugin_executeK8sMultiCanaryCleanStage_multipleTargets(t *testing.T) {

input := &sdk.ExecuteStageInput[kubeconfig.KubernetesApplicationSpec]{
Request: sdk.ExecuteStageRequest[kubeconfig.KubernetesApplicationSpec]{
StageName: "K8S_CANARY_CLEAN",
StageName: "K8S_MULTI_CANARY_CLEAN",
StageConfig: []byte(`{}`),
TargetDeploymentSource: sdk.DeploymentSource[kubeconfig.KubernetesApplicationSpec]{
ApplicationDirectory: filepath.Join("testdata", "simple"),
Expand Down Expand Up @@ -548,7 +548,7 @@ func TestPlugin_executeK8sMultiCanaryCleanStage_withCreateService(t *testing.T)

input := &sdk.ExecuteStageInput[kubeconfig.KubernetesApplicationSpec]{
Request: sdk.ExecuteStageRequest[kubeconfig.KubernetesApplicationSpec]{
StageName: "K8S_CANARY_ROLLOUT",
StageName: "K8S_MULTI_CANARY_ROLLOUT",
StageConfig: []byte(`{"createService": true}`),
TargetDeploymentSource: sdk.DeploymentSource[kubeconfig.KubernetesApplicationSpec]{
ApplicationDirectory: configDir,
Expand Down Expand Up @@ -590,7 +590,7 @@ func TestPlugin_executeK8sMultiCanaryCleanStage_withCreateService(t *testing.T)
require.True(t, ok)

ok = t.Run("execute canary clean stage", func(t *testing.T) {
input.Request.StageName = "K8S_CANARY_CLEAN"
input.Request.StageName = "K8S_MULTI_CANARY_CLEAN"
input.Request.StageConfig = []byte(`{}`)

status := plugin.executeK8sMultiCanaryCleanStage(ctx, input, deployTarget)
Expand Down Expand Up @@ -621,7 +621,7 @@ func TestPlugin_executeK8sMultiCanaryCleanStage_withoutCreateService(t *testing.

input := &sdk.ExecuteStageInput[kubeconfig.KubernetesApplicationSpec]{
Request: sdk.ExecuteStageRequest[kubeconfig.KubernetesApplicationSpec]{
StageName: "K8S_CANARY_ROLLOUT",
StageName: "K8S_MULTI_CANARY_ROLLOUT",
StageConfig: []byte(`{}`),
TargetDeploymentSource: sdk.DeploymentSource[kubeconfig.KubernetesApplicationSpec]{
ApplicationDirectory: configDir,
Expand Down Expand Up @@ -664,7 +664,7 @@ func TestPlugin_executeK8sMultiCanaryCleanStage_withoutCreateService(t *testing.
require.True(t, ok)

ok = t.Run("execute canary clean stage", func(t *testing.T) {
input.Request.StageName = "K8S_CANARY_CLEAN"
input.Request.StageName = "K8S_MULTI_CANARY_CLEAN"
input.Request.StageConfig = []byte(`{}`)

status := plugin.executeK8sMultiCanaryCleanStage(ctx, input, deployTarget)
Expand Down
12 changes: 6 additions & 6 deletions pkg/app/pipedv1/plugin/kubernetes_multicluster/deployment/pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,17 @@ const (
// StageK8sMultiRollback represents the state where all deployed resources should be rollbacked.
StageK8sMultiRollback = "K8S_MULTI_ROLLBACK"
// StageK8sMultiCanaryRollout represents the state where the new version is deployed as CANARY to all targets.
StageK8sMultiCanaryRollout = "K8S_CANARY_ROLLOUT"
StageK8sMultiCanaryRollout = "K8S_MULTI_CANARY_ROLLOUT"
// StageK8sMultiCanaryClean represents the state where all canary resources should be removed.
StageK8sMultiCanaryClean = "K8S_CANARY_CLEAN"
StageK8sMultiCanaryClean = "K8S_MULTI_CANARY_CLEAN"
// StageK8sMultiPrimaryRollout represents the state where the new version is promoted as PRIMARY to all targets.
StageK8sMultiPrimaryRollout = "K8S_PRIMARY_ROLLOUT"
StageK8sMultiPrimaryRollout = "K8S_MULTI_PRIMARY_ROLLOUT"
// StageK8sMultiBaselineRollout represents the state where the current version is deployed as BASELINE to all targets.
StageK8sMultiBaselineRollout = "K8S_BASELINE_ROLLOUT"
StageK8sMultiBaselineRollout = "K8S_MULTI_BASELINE_ROLLOUT"
// StageK8sMultiBaselineClean represents the state where all baseline resources should be removed.
StageK8sMultiBaselineClean = "K8S_BASELINE_CLEAN"
StageK8sMultiBaselineClean = "K8S_MULTI_BASELINE_CLEAN"
// StageK8sMultiTrafficRouting represents the state where traffic is routed between variants.
StageK8sMultiTrafficRouting = "K8S_TRAFFIC_ROUTING"
StageK8sMultiTrafficRouting = "K8S_MULTI_TRAFFIC_ROUTING"
)

var allStages = []string{
Expand Down
Loading