Open
Conversation
AdamKorcz
force-pushed
the
add-datetime-fuzzer
branch
from
361a5b8 to
9f80b17
Compare
AdamKorcz
force-pushed
the
add-datetime-fuzzer
branch
from
9f80b17 to
9195c9d
Compare
| hour = fdp.ConsumeIntInRange(0, 23) | ||
| minute = fdp.ConsumeIntInRange(0, 59) | ||
| second = fdp.ConsumeIntInRange(0, 59) | ||
| datetime(year, month, day, hour, minute, second).strftime(fmt) |
Member
There was a problem hiding this comment.
strftime is quite a thin wrapper around the C lib's strftime, and this is also quite inefficient IMO (the hypothesis PR linked earlier would be far better), as such I don't think this fuzzing is worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a structured fuzzer for the
_datetimeC module (Modules/_datetimemodule.c). It has two main branches: parsing and formatting. The parsing branch feeds fuzzed Unicode strings intodate.fromisoformat(),time.fromisoformat(), anddatetime.fromisoformat()to stress the C-level ISO 8601 parser. The formatting branch constructs valid date, time, and datetime objects with fuzzed field values and then callsstrftime()with fuzz-generated format strings, exercising the C formatter's handling of arbitrary directives and edge-case field combinations.