-
-
Notifications
You must be signed in to change notification settings - Fork 7
Add fuzzer for datetime module #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdamKorcz
wants to merge
1
commit into
python:main
Choose a base branch
from
AdamKorcz:add-datetime-fuzzer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+91
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| from fuzzeddataprovider import FuzzedDataProvider | ||
| from datetime import date, time, datetime | ||
|
|
||
| # Parse target constants (op_parse) | ||
| PARSE_DATE_FROMISOFORMAT = 0 | ||
| PARSE_TIME_FROMISOFORMAT = 1 | ||
| PARSE_DATETIME_FROMISOFORMAT = 2 | ||
| PARSE_DATETIME_STRPTIME = 3 | ||
|
|
||
| # Format target constants (op_format) | ||
| FORMAT_DATE = 0 | ||
| FORMAT_TIME = 1 | ||
| FORMAT_DATETIME = 2 | ||
|
|
||
| OP_PARSE = 0 | ||
| OP_FORMAT = 1 | ||
|
|
||
| STRPTIME_FORMATS = [ | ||
| "%Y-%m-%d", | ||
| "%Y-%m-%d %H:%M:%S", | ||
| "%d/%m/%Y", | ||
| "%m/%d/%Y", | ||
| "%Y%m%d", | ||
| "%H:%M:%S", | ||
| "%I:%M %p", | ||
| "%Y-%m-%dT%H:%M:%S", | ||
| "%a %b %d %H:%M:%S %Y", | ||
| "%c", | ||
| ] | ||
|
|
||
|
|
||
| def op_parse(fdp): | ||
| s = fdp.ConsumeUnicode(fdp.ConsumeIntInRange(1, 100)) | ||
| if not s: | ||
| return | ||
| target = fdp.ConsumeIntInRange(PARSE_DATE_FROMISOFORMAT) | ||
| if target == PARSE_DATE_FROMISOFORMAT: | ||
| date.fromisoformat(s) | ||
| elif target == PARSE_TIME_FROMISOFORMAT: | ||
| time.fromisoformat(s) | ||
| elif target == PARSE_DATETIME_FROMISOFORMAT: | ||
| datetime.fromisoformat(s) | ||
|
|
||
|
|
||
| def op_format(fdp): | ||
| fmt = fdp.ConsumeUnicode(fdp.ConsumeIntInRange(1, 100)) | ||
| if not fmt: | ||
| return | ||
| target = fdp.ConsumeIntInRange(FORMAT_DATE, FORMAT_DATETIME) | ||
| if target == FORMAT_DATE: | ||
| year = fdp.ConsumeIntInRange(1, 9999) | ||
| month = fdp.ConsumeIntInRange(1, 12) | ||
| day = fdp.ConsumeIntInRange(1, 28) | ||
| date(year, month, day).strftime(fmt) | ||
| elif target == FORMAT_TIME: | ||
| hour = fdp.ConsumeIntInRange(0, 23) | ||
| minute = fdp.ConsumeIntInRange(0, 59) | ||
| second = fdp.ConsumeIntInRange(0, 59) | ||
| time(hour, minute, second).strftime(fmt) | ||
| elif target == FORMAT_DATETIME: | ||
| year = fdp.ConsumeIntInRange(1, 9999) | ||
| month = fdp.ConsumeIntInRange(1, 12) | ||
| day = fdp.ConsumeIntInRange(1, 28) | ||
| hour = fdp.ConsumeIntInRange(0, 23) | ||
| minute = fdp.ConsumeIntInRange(0, 59) | ||
| second = fdp.ConsumeIntInRange(0, 59) | ||
| datetime(year, month, day, hour, minute, second).strftime(fmt) | ||
|
|
||
|
|
||
| # Fuzzes the _datetime C module (Modules/_datetimemodule.c). | ||
| # Exercises ISO format parsing (date/time/datetime.fromisoformat), | ||
| # strptime with multiple predefined format strings, and strftime with | ||
| # fuzz-generated format strings. Only operations that pass fuzzed | ||
| # text into the C parser are included. | ||
| def FuzzerRunOne(FuzzerInput): | ||
| if len(FuzzerInput) < 1 or len(FuzzerInput) > 0x10000: | ||
| return | ||
| fdp = FuzzedDataProvider(FuzzerInput) | ||
| op = fdp.ConsumeIntInRange(OP_PARSE, OP_FORMAT) | ||
| try: | ||
| if op == OP_PARSE: | ||
| op_parse(fdp) | ||
| elif op == OP_FORMAT: | ||
| op_format(fdp) | ||
| except Exception: | ||
| pass | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strftimeis quite a thin wrapper around the C lib'sstrftime, and this is also quite inefficient IMO (the hypothesis PR linked earlier would be far better), as such I don't think this fuzzing is worth it.