Skip to content

Small test fixups#2942

Open
will-v-pi wants to merge 5 commits into
developfrom
test-fixups
Open

Small test fixups#2942
will-v-pi wants to merge 5 commits into
developfrom
test-fixups

Conversation

@will-v-pi
Copy link
Copy Markdown
Contributor

Tests with stdio_usb need the final output to be flushed before exiting (which is done by stdio_deinit_all), otherwise they don't always print PASSED

hardware_sync_spin_lock_test takes too long on RP2040, so increase the timeout as it was close to timing out on RP2350 anyway

@will-v-pi will-v-pi added this to the 2.2.1 milestone May 15, 2026
Comment thread test/pico_test/include/pico/test.h Outdated
peterharperuk
peterharperuk previously approved these changes May 15, 2026
Comment thread test/pico_test/include/pico/test.h Outdated
@lurch
Copy link
Copy Markdown
Contributor

lurch commented May 15, 2026

IIRC (when I was looking at one of Graham's PRs) there are also some tests that call puts directly rather than using the PICOTEST_ macros. Do those tests also need to be updated to do an explicit stdio_deinit_all()?

Ahh, see my comment here #2897 (comment)

@will-v-pi
Copy link
Copy Markdown
Contributor Author

IIRC (when I was looking at one of Graham's PRs) there are also some tests that call puts directly rather than using the PICOTEST_ macros. Do those tests also need to be updated to do an explicit stdio_deinit_all()?

Ahh, see my comment here #2897 (comment)

Those tests don't use stdio_usb, so don't need to call stdio_deinit_all(), so I won't update them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants