Skip to content

Small test fixups #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kilograham merged 5 commits into from
May 16, 2026
+14 −4
Merged

Small test fixups #2942

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d300c4
Deinit stdio in PICOTEST_END_TEST when using stdio_usb
will-v-pi May 8, 2026
843bd87
Increase timeout on hardware_sync_spin_lock_test
will-v-pi May 8, 2026
94f629c
Always call stdio_deinit_all() before exiting
will-v-pi May 15, 2026
06732c9
Add host stdio_deinit_all
will-v-pi May 15, 2026
4c061c4
Split onto multiple lines
will-v-pi May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/hardware_sync_spin_lock_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@ pico_add_extra_outputs(hardware_sync_spin_lock_test)
target_compile_definitions(hardware_sync_spin_lock_test PRIVATE
PICO_STDOUT_MUTEX=0
)

set_target_properties(hardware_sync_spin_lock_test PROPERTIES PICO_TEST_TIMEOUT 10)
7 changes: 7 additions & 0 deletions test/pico_test/include/pico/test.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,17 @@ but not sure that is implemented yet.
return -1; \
}

#if LIB_PICO_STDIO_USB // Must deinit before exiting, to avoid losing final output
Comment thread
will-v-pi marked this conversation as resolved.
Outdated
#define PICOTEST_END_TEST() if (picotest_error_code != 0) \
{printf("%s: Failed\n", picotest_description); stdio_deinit_all(); return -1;} \
else \
{printf("%s: Success\n", picotest_description); puts("PASSED"); stdio_deinit_all(); return 0;}
#else
#define PICOTEST_END_TEST() if (picotest_error_code != 0) \
{printf("%s: Failed\n", picotest_description); return -1;} \
else \
{printf("%s: Success\n", picotest_description); puts("PASSED"); return 0;}
#endif


#endif
Loading