Repository navigation
feat(transport): parameterize buffer limits and pool capacities with Kconfig - #112
Merged
Merged
Conversation
…with Kconfig - Replace hardcoded buffer sizes and pool counts in zenoh_transport.c with Kconfig options: - CONFIG_ZENBEDDED_MAX_NODE_NAME_LEN (default 64) - CONFIG_ZENBEDDED_MAX_TOPIC_NAME_LEN (default 64, sizes mangled_topic in pub/sub) - CONFIG_ZENBEDDED_MAX_KEYEXPR_LEN (default 512) - CONFIG_ZENBEDDED_MAX_LOCATOR_LEN (default 128) - CONFIG_ZENBEDDED_MAX_PUBLISHERS (default 10) - CONFIG_ZENBEDDED_MAX_SUBSCRIBERS (default 10) - CONFIG_ZENBEDDED_TIER1_MAX_RX_BUFFER_SIZE (default 1024) - CONFIG_ZENBEDDED_TIER2_MAX_RX_BUFFER_SIZE (default 64) - Add defensive #ifndef preprocessor fallbacks in zenoh_transport.c - Ensure explicit null termination on current_node_name in zenbedded_transport_init
EnejiOhieku
requested review from
ShahazadAbdulla,
bmagyar,
christophfroehlich,
kamal2730 and
kpochwala
October 19, 2026 14:55
Member
|
Reviewing it. |
ShahazadAbdulla
left a comment
ShahazadAbdulla
left a comment
Member
There was a problem hiding this comment.
Rest all looks good to me.
kpochwala
approved these changes
Oct 21, 2026
kpochwala
left a comment
kpochwala
left a comment
Member
There was a problem hiding this comment.
Generally approve, however I think the default values and their help comments could be tweaked.
…ime heuristics and parameterize type length - Remove manual ZENBEDDED_MAX_KEYEXPR_LEN Kconfig knob - Add CONFIG_ZENBEDDED_MAX_TYPE_NAME_LEN (default 64) under ZENBEDDED_TIER_1 - Calculate exact compile-time key expression buffer sizes for Tier 1 and Tier 2 - Bound node liveliness, topic key expressions, and entity liveliness tokens - Update snprintf calls to use sizeof(buffer) for bounds safety - Adjust locator length default to 32 and pub/sub pool ranges to 0..64 - Add static specifier to rx_buf in internal_sub_handler
kpochwala
approved these changes
Oct 21, 2026
ShahazadAbdulla
approved these changes
Oct 21, 2026
Member
|
Thank you, this PR is ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces hardcoded magic constant buffer sizes and static pool capacities across
zenbedded_transport/src/zenoh_transport.cwith configurable Zephyr Kconfig symbols defined in zenbedded_transport/Kconfig`.Is this a user-facing behavior change?
No breaking changes. All default Kconfig values match the existing constants.
Did you use Generative AI?
Yes, Gemini.