Fix pluralization in ros2 trace output - #169
Conversation
Signed-off-by: Shravan Deva <devashravan7@gmail.com>
christophebedard
left a comment
There was a problem hiding this comment.
Thanks for the PR! I just have one minor comment.
Signed-off-by: Shravan Deva <devashravan7@gmail.com>
|
Hi @christophebedard , I've corrected the mistake you pointed out. Can you please review these changes? |
christophebedard
left a comment
There was a problem hiding this comment.
Looks good, thanks for the PR and for making the change!
|
Pulls: #169 |
|
Hi @christophebedard , it looks like the Windows build is failing, but I don’t think it’s related to the changes I made in this PR. Could you please confirm when you get a chance? |
|
Yeah, that's related to https://github.com/ros2-rust/rosidl_rust. I retriggered the Windows job. Let's see if their new fix works (ros2-rust/rosidl_rust#3), otherwise I'll have to trigger a fresh set of CI jobs so that this repo is not included (ros2/ros2#1677). |
|
Got it! I'll use this opportunity to learn more about GitHub CI. |
|
Alright, ROS 2 CI passed, so this is ready! Thanks again for the PR. |
Signed-off-by: Shravan Deva <devashravan7@gmail.com>
This PR fixes a small issue in the output of the
ros2 tracecommand. Earlier, even when only one event was enabled, the terminal would display:userspace tracing enabled (1 events)This has now been updated to correctly handle singular and plural forms:
userspace tracing enabled (1 event)I’ve tested this locally using a source build of ROS 2 Rolling. Attached below is the terminal output for reference.
Let me know if any changes are needed!