Skip to content

Fix pluralization in ros2 trace output #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christophebedard merged 2 commits into from
Apr 26, 2025
Merged

Fix pluralization in ros2 trace output #169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2641c2
Fix pluralization in ros2 trace output
devashravan Apr 24, 2025
b00c401
Update output of ros2 trace command
devashravan Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tracetools_trace/tracetools_trace/trace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,25 +45,29 @@ def _display_info(
display_list: bool,
) -> None:
if ros_events:
print(f'userspace tracing enabled ({len(ros_events)} events)')
event_str = 'events' if len(ros_events) > 1 else 'event'
print(f'userspace tracing enabled ({len(ros_events)} {event_str})')
if display_list:
print_names_list(ros_events)
else:
print('userspace tracing disabled')
if kernel_events:
print(f'kernel tracing enabled ({len(kernel_events)} events)')
event_str = 'events' if len(kernel_events) > 1 else 'event'
print(f'kernel tracing enabled ({len(kernel_events)} {event_str})')
if display_list:
print_names_list(kernel_events)
else:
print('kernel tracing disabled')
if syscalls:
print(f'syscall tracing enabled ({len(syscalls)} syscalls)')
syscall_str = 'syscalls' if len(syscalls) > 1 else 'syscall'
print(f'syscall tracing enabled ({len(syscalls)} {syscall_str})')
if display_list:
print_names_list(syscalls)
else:
print('syscalls tracing disabled')
if len(context_fields) > 0:
print(f'context ({len(context_fields)} fields)')
field_str = 'fields' if len(context_fields) > 1 else 'field'
print(f'context ({len(context_fields)} {field_str})')
if display_list:
print_names_list(context_fields)

Expand Down