Skip to content

consolidate test binaries - #1825

Open
ahcorde wants to merge 1 commit into
rollingfrom
ahcorde/rolling/consolidate_test_binaries
Open

consolidate test binaries#1825
ahcorde wants to merge 1 commit into
rollingfrom
ahcorde/rolling/consolidate_test_binaries

Conversation

@ahcorde

@ahcorde ahcorde commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

In order to build faster. Consolidate 28 single-suite gmock binaries into one shared-main test executable.

@mjcarroll do you have an opinion here ?

Around 1 min less ot time in my computer.

Did you use Generative AI?

Claude Opus 4.7

@ahcorde ahcorde self-assigned this Jul 23, 2026
@ahcorde
ahcorde requested a review from mjcarroll July 23, 2026 16:47
@mergify

mergify Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
ahcorde force-pushed the ahcorde/rolling/consolidate_test_binaries branch from efa0b18 to 3589417 Compare July 23, 2026 20:04
@ahcorde ahcorde changed the title Ahcorde/rolling/consolidate test binaries consolidate test binaries Jul 23, 2026
@mjcarroll

Copy link
Copy Markdown
Member

I think this is a totally reasonable move, should accelerate builds. I suppose if you have a single test that segfaults it can take down the whole binary, but at that point we probably have larger concerns?

@ahcorde

ahcorde commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

I think this is a totally reasonable move, should accelerate builds. I suppose if you have a single test that segfaults it can take down the whole binary, but at that point we probably have larger concerns?

If something is failing probably you need to debug and you can comment the other cpp files, just to check want you want.

@mjcarroll

Copy link
Copy Markdown
Member

I think this is a totally reasonable move, should accelerate builds. I suppose if you have a single test that segfaults it can take down the whole binary, but at that point we probably have larger concerns?

If something is failing probably you need to debug and you can comment the other cpp files, just to check want you want.

Yeah, or do command line test filtering, I suppose.

@ahcorde

ahcorde commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

I think this is a totally reasonable move, should accelerate builds. I suppose if you have a single test that segfaults it can take down the whole binary, but at that point we probably have larger concerns?

If something is failing probably you need to debug and you can comment the other cpp files, just to check want you want.

Yeah, or do command line test filtering, I suppose.

yes, that's another option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants