Repository navigation
Fix aggregate version for Central Portal releases - #272
Merged
Merged
Conversation
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stable publishing builds and signs every artifact, then
sonaReleaserejects the unpublished root project's dynver-generated-SNAPSHOTversion. SettingisSnapshot := falsecorrected staging routing but did not satisfy this separate string-based check.Give the unpublished aggregate an explicit snapshot/release version and validate its version before publishing. Add a CI regression check that accepts release mode and deliberately rejects a snapshot aggregate. Advance common-protos and PGV to build 1 so retries preserve the failed build-0 tags; Pub/Sub and Dataproc have not been tagged remotely. Include the clarified protobuf-java override instructions in the README.
Validation: the new sbt release regression check, four Python release-selection tests, sbt formatting, actionlint, and diff checks pass. The failed build-0 releases uploaded nothing to Central Portal.