feat: #9 Design 800×480 house-ad source with QR CTA

[patoperpetua]

Summary

• Editable 800×480 B/W InkAds house/fallback creative under src/marketing/house-ad/
• Large QR (260px, 4-module quiet zone) encoding the stable marketing redirect https://inkads.poc.singletonsd.com/go (destination configured via marketing /go)
• pnpm generate:house-ad-qr regenerates qr-go.svg via qrcode devDependency

Closes #9

Test plan

• pnpm generate:house-ad-qr
• pnpm validate
• pnpm test
• pnpm build
• Visual check of house-ad-800x480.svg at venue distance / mock

Made with Cursor

Summary by CodeRabbit

• New Features

  • Added an 800×480 monochrome house advertisement with a QR code linking to the configured redirect URL.
  • Added a command to regenerate the house-ad QR asset, including support for custom destinations and output paths.

• Documentation

  • Documented the house-ad layout, fallback usage, QR destination, regeneration process, SVG requirements, and readability guidelines.

[greptile-apps]

patoperpetua has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• src/marketing/house-ad/house-ad-800x480.svg is excluded by !**/*.svg

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: c721780b-0a85-4baa-90ca-2de0066400a3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 74fa6371-d702-456c-b0c3-42dadec991dc

📥 Commits

Reviewing files that changed from the base of the PR and between b78df6e and 693caec.

⛔ Files ignored due to path filters (3)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
• src/marketing/house-ad/house-ad-800x480.svg is excluded by !**/*.svg
• src/marketing/house-ad/qr-go.svg is excluded by !**/*.svg

📒 Files selected for processing (5)

• meta.json
• package.json
• scripts/generate-house-ad-qr.mjs
• src/marketing/README.md
• src/marketing/house-ad/README.md

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

---

📝 Walkthrough

Walkthrough

The PR adds a houseAd inventory path, documents the 800×480 house-ad asset, and adds a Node.js QR generator with a package script and qrcode development dependency.

Changes

House-ad QR asset

Layer / File(s)	Summary
House-ad asset contract meta.json, src/marketing/README.md, src/marketing/house-ad/README.md	The inventory defines the houseAd path. Marketing documentation describes the fallback asset, composition, QR target, SVG constraints, and readability requirements.
QR generation workflow package.json, scripts/generate-house-ad-qr.mjs	The generate:house-ad-qr script uses qrcode to generate qr-go.svg, create its destination directory, and report generation metadata.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant PackageScript
  participant GenerateHouseAdQr
  participant QrcodeLibrary
  participant FileSystem
  PackageScript->>GenerateHouseAdQr: run generate:house-ad-qr
  GenerateHouseAdQr->>QrcodeLibrary: encode HOUSE_AD_QR_TARGET as SVG
  GenerateHouseAdQr->>FileSystem: create directory and write qr-go.svg
  FileSystem-->>GenerateHouseAdQr: return output metadata

Loading

Merge Risk: ⚪ Minimal · up to 693ca

The house-ad asset documentation and QR generation workflow introduce no confirmed merge-blocking risk.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (4 skipped: 4 …	Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check	❓ Inconclusive	For issue #9, the README documents the 800×480 composition, fallback use, QR target URL, regeneration command, and venue guidelines. The generator and package script support QR asset generation. Howev…	Provide reviewable evidence for the excluded SVG assets, or otherwise establish the editable source, QR quiet zone, visual composition, and venue-distance readability. The current evidence cannot decide these issue #9 requirements.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding an editable 800×480 house-ad source with a QR call to action.
Out of Scope Changes check	✅ Passed	The changes stay within issue #9 scope. The inventory entry, QR generator, development dependency, marketing documentation, and house-ad documentation support asset design, generation, and render/publ…

Full details: Linked Issues check

Explanation

For issue #9, the README documents the 800×480 composition, fallback use, QR target URL, regeneration command, and venue guidelines. The generator and package script support QR asset generation. However, the source asset src/marketing/house-ad/house-ad-800x480.svg and generated src/marketing/house-ad/qr-go.svg are excluded by the !**/*.svg rule. The excluded files are required to verify the editable source, quiet zone, monochrome-friendly composition, hospitality-generic design, and venue-distance readability. The summary also states that visual mock review remains pending.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (4 skipped: 4 unsupported.)

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/9-house-ad-design

---

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

patoperpetua has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.