Skip to content

fix(query): retry failed reads after hydration - #727

Closed
yuxino wants to merge 1 commit into
solidjs:nextfrom
febug:fix/query-retry-after-rejection
Closed

yuxino wants to merge 1 commit into
solidjs:nextfrom
febug:fix/query-retry-after-rejection

Conversation

@yuxino

@yuxino yuxino commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Fixes #726.

When a query failed, hitting Retry in an <Errored> fallback could read the same rejected promise from the router cache. The fallback stayed visible and the query did not run again.

A rejected client entry remains available while Solid claims the server-rendered fallback. Outside hydration, the next read can fetch again immediately. Concurrent reads still share their in-flight request, and an older rejected request leaves a newer cache value intact.

Verified the failing retry against the published 2.0.0-next.44 package. Added regressions for clicking Retry and for reusing a rejected server flight during hydration before retrying it. The client and server suites, type checks, and build pass.

@changeset-bot

changeset-bot Bot commented Nov 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3272eff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member

Thanks, this is the right fix. We couldn't push to the fork from here, so it lands through #733, which keeps your commit as-is. On top, it marks a rejected entry with a negative stamp instead of a WeakSet. The behavior is the same, and the client cost drops from +26 B to +6 B brotli. Closing this in favor of #733.


Generated by Claude Code

@ryansolid ryansolid closed this Nov 17, 2026
ryansolid added a commit that referenced this pull request Nov 17, 2026
fix(query): retry failed reads after hydration (#727, trimmed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants