Repository navigation
fix(query): retry failed reads after hydration (#727, trimmed) - #733
Merged
Merged
Conversation
… WeakSet Same semantics (never fresh outside hydration, still truthy so hydration reuses the server rejection); +6 B br instead of +26 B on the client bundle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWKegJTJmg5nmox4u4v
🦋 Changeset detectedLatest commit: f3bde6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
This carries @yuxino's #727 (fixes #726) with their commit kept as-is. The PR comes from a fork this session can't push to, so the trim rides on top here.
Trim: a rejected client entry is marked with a negative stamp (
cached[0] = -1) instead of a module-levelWeakSet. The semantics are the same:<Errored>reset()retry right away.query.setoverwrites the stamp.Client bundle (
solidcondition,isServer=false, terser and brotli): 41,497 to 41,527 B min and 14,205 to 14,211 B br (+6 B). #727 as written was +26 B br.Local: client 758/758, server 107/107, types pass. #727's own regressions are included and pass.
Closes #726.
Generated by Claude Code