Skip to content

fix(query): retry failed reads after hydration (#727, trimmed) - #733

Merged
ryansolid merged 3 commits into
nextfrom
claude/router-query-retry-727
Nov 17, 2026
Merged

ryansolid merged 3 commits into
nextfrom
claude/router-query-retry-727

Conversation

@ryansolid

Copy link
Copy Markdown
Member

Requested by Ryan · project thread

This carries @yuxino's #727 (fixes #726) with their commit kept as-is. The PR comes from a fork this session can't push to, so the trim rides on top here.

Trim: a rejected client entry is marked with a negative stamp (cached[0] = -1) instead of a module-level WeakSet. The semantics are the same:

  • The entry is never fresh outside hydration, so the next read refetches. This is what lets <Errored> reset() retry right away.
  • The stamp is still truthy, so a read during hydration keeps reusing the server's rejection. No refetch on hydration.
  • A refetch or query.set overwrites the stamp.

Client bundle (solid condition, isServer=false, terser and brotli): 41,497 to 41,527 B min and 14,205 to 14,211 B br (+6 B). #727 as written was +26 B br.

Local: client 758/758, server 107/107, types pass. #727's own regressions are included and pass.

Closes #726.


Generated by Claude Code

yuxino and others added 3 commits November 15, 2026 08:31
… WeakSet

Same semantics (never fresh outside hydration, still truthy so hydration
reuses the server rejection); +6 B br instead of +26 B on the client bundle.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWKegJTJmg5nmox4u4v
@changeset-bot

changeset-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f3bde6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid
ryansolid merged commit 92feaa8 into next Nov 17, 2026
4 checks passed
@ryansolid
ryansolid deleted the claude/router-query-retry-727 branch November 17, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants