[EmbeddedMetadata] fix keywords error and add test coverage#2741
Open
spaceyuck wants to merge 4 commits into
Open
[EmbeddedMetadata] fix keywords error and add test coverage#2741spaceyuck wants to merge 4 commits into
spaceyuck wants to merge 4 commits into
Conversation
…lse' referencing undeclared variable This can probably be more elegant, but I truly know very little about python so wanted to make as few changes as possible.
…basic unit tests this required renaming the python file, to make it importable unit tests run both exiftool and pyexiv2 methods,and as such require both installed and working
Member
? |
Contributor
I see no value in it for the end user. I would exclude it. |
Contributor
Author
python importable module names can't contain '-', which the old file name did
I have moved the tests and test data into a subfolder for the scraper under a new top folder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an error in the keywords to tags logic, based on report by @NoNameHeath in the forum.
closes #2738
closes #2737
Scraper type(s)
Examples to test
included in folder test-data
Short description
Aside from the small fix, this also adds unit test coverage (which necessitated a python file rename, and some small structural changes to be able to force both supported source library modes).
Here's a question: is it OK to place unit tests and test data within the same directory as the scraper? I couldn't find any other example with a unit test.