fix(tx): support EIP-155 unsigned encoding and widen v to uint256 in LegacyTransactionLib - #140
Open
yappermoar-boop wants to merge 1 commit into
Conversation
…LegacyTransactionLib
yappermoar-boop
requested review from
0xrusowsky,
grandizzy and
onbjerg
as code owners
August 24, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In LegacyTransactionLib.sol, widened v from uint8 to uint256 in encodeWithSignature to prevent overflow for EIP-155 chain IDs (where v = chainId * 2 + 35 + yParity > 255 for chainId > 110). Also added encode(self, vm, chainId) overload for EIP-155 9-field replay-protected unsigned transaction encoding.