Skip to content

fix(tx): support EIP-155 unsigned encoding and widen v to uint256 in LegacyTransactionLib #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yappermoar-boop wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(tx): support EIP-155 unsigned encoding and widen v to uint256 in LegacyTransactionLib #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/tx/LegacyTransactionLib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ library LegacyTransactionLib {
return self;
}

/// @notice RLP encodes the unsigned transaction (6 fields).
/// @notice RLP encodes the unsigned transaction (6 fields pre-EIP-155).
/// @dev Legacy transactions have no type prefix.
function encode(LegacyTransaction memory self, VmRlp vm) internal pure returns (bytes memory) {
bytes[] memory items = new bytes[](6);
Expand All @@ -86,9 +86,26 @@ library LegacyTransactionLib {
return TxRlp.encodeList(vm, items);
}

/// @notice RLP encodes the unsigned EIP-155 transaction with replay protection (9 fields).
/// @dev Format: RLP([nonce, gasPrice, gasLimit, to, value, data, chainId, 0, 0])
function encode(LegacyTransaction memory self, VmRlp vm, uint64 chainId) internal pure returns (bytes memory) {
bytes[] memory items = new bytes[](9);
items[0] = TxRlp.encodeUint(self.nonce);
items[1] = TxRlp.encodeUint(self.gasPrice);
items[2] = TxRlp.encodeUint(self.gasLimit);
items[3] = self.to == address(0) ? TxRlp.encodeNone() : TxRlp.encodeAddress(self.to);
items[4] = TxRlp.encodeUint(self.value);
items[5] = self.data;
items[6] = TxRlp.encodeUint(chainId);
items[7] = TxRlp.encodeUint(0);
items[8] = TxRlp.encodeUint(0);

return TxRlp.encodeList(vm, items);
}

/// @notice RLP encodes the signed transaction (9 fields).
/// @dev Legacy transactions have no type prefix.
function encodeWithSignature(LegacyTransaction memory self, VmRlp vm, uint8 v, bytes32 r, bytes32 s)
/// @dev Legacy transactions have no type prefix. `v` is uint256 to support EIP-155 chain IDs.
function encodeWithSignature(LegacyTransaction memory self, VmRlp vm, uint256 v, bytes32 r, bytes32 s)
internal
pure
returns (bytes memory)
Expand Down