fix(react-best-practices): false examples to require 'use client' in react-best-practices#217
Open
Zero-1016 wants to merge 1 commit intovercel-labs:mainfrom
Open
Conversation
- bundle-defer-third-party: extract dynamic import into a separate Client Component (AnalyticsProvider) so RootLayout remains a Server Component - bundle-dynamic-imports: add 'use client' directive to component using ssr: false - AGENTS.md: apply same fixes to matching examples Fixes vercel-labs#216
|
@Zero-1016 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundle-defer-third-party: Extract dynamic import withssr: falseinto a separate Client Component (AnalyticsProvider) soRootLayoutremains a Server Componentbundle-dynamic-imports: Add'use client'directive to the component usingssr: falseAGENTS.md: Apply the same fixes to matching examplesProblem
ssr: falseis not allowed in Server Components. The previous examples showed an incorrect pattern that would throw a Next.js runtime error when used insideRootLayout(a ServerComponent).
Changes
skills/react-best-practices/rules/bundle-defer-third-party.mdskills/react-best-practices/rules/bundle-dynamic-imports.mdskills/react-best-practices/AGENTS.mdCloses #216