Skip to content

fix(react-best-practices): false examples to require 'use client' in react-best-practices #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zero-1016 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(react-best-practices): false examples to require 'use client' in react-best-practices #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified skills/react-best-practices.zip
View file
Open in desktop
Binary file not shown.
16 changes: 15 additions & 1 deletion skills/react-best-practices/AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,19 +528,31 @@ export default function RootLayout({ children }) {
**Correct: loads after hydration**

```tsx
// components/analytics-provider.tsx
'use client'

import dynamic from 'next/dynamic'

const Analytics = dynamic(
() => import('@vercel/analytics/react').then(m => m.Analytics),
{ ssr: false }
)

export function AnalyticsProvider() {
return <Analytics />
}
```

```tsx
// app/layout.tsx — remains a Server Component
import { AnalyticsProvider } from '@/components/analytics-provider'

export default function RootLayout({ children }) {
return (
<html>
<body>
{children}
<Analytics />
<AnalyticsProvider />
</body>
</html>
)
Expand All @@ -566,6 +578,8 @@ function CodePanel({ code }: { code: string }) {
**Correct: Monaco loads on demand**

```tsx
'use client'

import dynamic from 'next/dynamic'

const MonacoEditor = dynamic(
Expand Down
14 changes: 13 additions & 1 deletion skills/react-best-practices/rules/bundle-defer-third-party.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,31 @@ export default function RootLayout({ children }) {
**Correct (loads after hydration):**

```tsx
// components/analytics-provider.tsx
'use client'

import dynamic from 'next/dynamic'

const Analytics = dynamic(
() => import('@vercel/analytics/react').then(m => m.Analytics),
{ ssr: false }
)

export function AnalyticsProvider() {
return <Analytics />
}
```

```tsx
// app/layout.tsx — remains a Server Component
import { AnalyticsProvider } from '@/components/analytics-provider'

export default function RootLayout({ children }) {
return (
<html>
<body>
{children}
<Analytics />
<AnalyticsProvider />
</body>
</html>
)
Expand Down
2 changes: 2 additions & 0 deletions skills/react-best-practices/rules/bundle-dynamic-imports.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ function CodePanel({ code }: { code: string }) {
**Correct (Monaco loads on demand):**

```tsx
'use client'

import dynamic from 'next/dynamic'

const MonacoEditor = dynamic(
Expand Down