Restore ReflectionClass template covariance in PHP 8.4 stub#11866
Open
roxblnfk wants to merge 1 commit into
Open
Restore ReflectionClass template covariance in PHP 8.4 stub#11866roxblnfk wants to merge 1 commit into
roxblnfk wants to merge 1 commit into
Conversation
The PHP 8.4 stub (added in 21fe8ef to type the lazy-object methods) redeclares ReflectionClass with an invariant `@template T of object`, dropping the `@template-covariant` used by the base Reflection.phpstub and Php80.phpstub. Because a redeclaration with an explicit @template overrides the inherited one, analysing code against PHP 8.4/8.5 makes `ReflectionClass<Foo>` no longer assignable to `ReflectionClass<object>`, producing false-positive InvalidArgument errors. The Php81/Php82 stubs redeclare ReflectionClass without an @template line and therefore correctly inherit the covariant parameter; only the 8.4 stub regressed. Restore `@template-covariant T as object` to match the base stub. Adds a regression test (gated to php_version 8.4) that fails on the 8.4/8.5 CI runners without this change.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHP 8.4 stub (added in 21fe8ef to type the lazy-object methods) redeclares ReflectionClass with an invariant
@template T of object, dropping the@template-covariantused by the base Reflection.phpstub and Php80.phpstub. Because a redeclaration with an explicit@templateoverrides the inherited one, analysing code against PHP 8.4/8.5 makesReflectionClass<Foo>no longer assignable toReflectionClass<object>, producing false-positive InvalidArgument errors.The Php81/Php82 stubs redeclare
ReflectionClasswithout an@templateline and therefore correctly inherit the covariant parameter; only the 8.4 stub regressed. Restore@template-covariant T as objectto match the base stub.Adds a regression test (gated to php_version 8.4) that fails on the 8.4/8.5 CI runners without this change.