Skip to content

Fix swallowed errors in session package - #1763

Open
aaronjwood wants to merge 1 commit into
vmware:engfrom
aaronjwood:fix-swallowed-errors
Open

Fix swallowed errors in session package#1763
aaronjwood wants to merge 1 commit into
vmware:engfrom
aaronjwood:fix-swallowed-errors

Conversation

@aaronjwood

Copy link
Copy Markdown
Contributor

All of this stuff was picked up by the linter we use (https://github.com/golangci/golangci-lint)

@manojkumarjain manojkumarjain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aaronjwood

Copy link
Copy Markdown
Contributor Author

Just wanted to follow up. Is there still an interest in merging this?

@aaronjwood

Copy link
Copy Markdown
Contributor Author

Hi, any update on this?

@mayank-avinetworks

Copy link
Copy Markdown
Contributor

Hi, any update on this?

Hello Aron,
Nothing a the moment, very occupied with critical tasks. we will try to review it soon

@legal-compliance-bot

Copy link
Copy Markdown

🛑 Legal Compliance Check Failed

Hi @aaronjwood, thank you for your contribution!

To merge this Pull Request, you must sign our DCO.

Note: Even if you signed off your commits locally (using git commit -s), you must post the comment below to register your signature with our automated system.
Note: This is a one-time process. Once signed, future contributions to this repository will be verified automatically.

1. Read the Document: Click here to read the DCO
2. Sign via Comment: Copy and paste the exact line below into a new comment on this Pull Request:

I have read the DCO Document and I hereby sign the DCO for this and all future contributions.

⏳ Processing Schedule:
Our 'Compliance Sweeper' runs automatically approximately every 15-20 minutes.
After you post the comment, your status will update automatically during the next scheduled run.
You do not need to take any further action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants