refactor(pxe): migrate CapsuleStore to BaseStagingStore - #101
Open
nchamo wants to merge 2 commits into
Open
Conversation
nchamo
marked this pull request as ready for review
August 27, 2026 21:26
This was referenced Aug 28, 2026
nchamo
force-pushed
the
nchamo/capsule-store-base-staging
branch
from
August 28, 2026 20:04
e7c4dd4 to
f3a9b99
Compare
nventuro
force-pushed
the
nchamo/capsule-store-base-staging
branch
from
August 28, 2026 21:17
f3a9b99 to
6130908
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CapsuleStoreonto theBaseStagingStore, following refactor(pxe): migrate RecipientTaggingStore to BaseStagingStore #94 and refactor(pxe): migrate FactStore to BaseStagingStore #98. The base supplies the staging buffer, the operation lock and the commit/discard lifecycle; theMap<slot, Buffer | null>tombstone model carries over unchanged as the change set, andapplyRollbackis a no-op since capsules are not anchored to a block.setCapsuleanddeleteCapsulebecome async, since every base-store operation goes throughwithChangeSet. This ripples toCapsuleServiceandUtilityExecutionOracle; the oracle dispatcher already awaits handler results, so the Noir boundary is unaffected.appendToCapsuleArray,setCapsuleArray,copyCapsule) no longer call the public setters from inside their own transaction, which would deadlock on the base's non-reentrant lock. They use private helpers instead, so each operation takes the lock exactly once.