Skip to content

Defender, Steelcreast and Bulwark no longer keep stances active when stunned/dead and display correct knockdown sprites. - #12613

Open
Venuska1117 wants to merge 9 commits into
cmss13-devs:masterfrom
Venuska1117:nu2-ex-stun
Open

Defender, Steelcreast and Bulwark no longer keep stances active when stunned/dead and display correct knockdown sprites.#12613
Venuska1117 wants to merge 9 commits into
cmss13-devs:masterfrom
Venuska1117:nu2-ex-stun

Conversation

@Venuska1117

@Venuska1117 Venuska1117 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Requesting Testmerge for this PR, there might be unintended side-effects.

Feedback:

https://discord.com/channels/150315577943130112/1464087612796174501

Detached from: #12601

About the pull request

Makes castes such as Defender, Steelcrest and Bulwark to display their knockdown sprites when stunned by explosives (or any other strong source of damage) and make them lose stances like fortify and reflective shield.

Also updates some code to use traits and "better" logic.

Fixes: #8287
Fixes: #12562
This PR also solves unintentional issue presented in other PR: #11976

Explain why it's good for the game

Shows to other people like marines or xenos, that Defender, Steelcrest or Bulwark are stunned from explosive and are vulnerable, showing visual sprite of knockdown, this PR also makes them lose stance from explosives, they already get stunned by explosive during stances, it was just not visible (other than blood sprites or fire sprites).

As for stance removal, such as Fortify and Reflective, this was decided after noticing that, stunned fortified defender still keep its 65 armor, this should not have place in game, this also goes for other abilities, with this change, stunned "defensive" xenos should be easier to kill, and for them, easier to escape when it goes bad.

Testing Video

▶️ New Fortified Defender reaction to explosives: This also works on steelcrest strain.
2026-07-03.18-14-57.mp4

Changelog

🆑 Venuska1117
balance: If Defender or Steelcrest is stunned, they lose their Fortify Stance.
balance: If Defender or Steelcrest is dead, they lose their Crest and Fortify Stance.
balance: If Bulwark is stunned, they lose their Reflective Stance.
balance: If Bulwark is dead, they lose their Encased Plates and Reflective Stance.
fix: Defender and Steelcrest now display "knockdown" sprite when stunned during lowered crest or fortify.
fix: Bulwark now display "knockdown" sprite when stunned during encased plates or reflective shield.
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jul 9, 2026
@Venuska1117 Venuska1117 changed the title Defender, Steelcreast and Bulwark no longer keep stance abilities active when stunned/dead. Defender, Steelcreast and Bulwark no longer keep stance abilities active when stunned/dead and display correct knockdown sprites. Jul 9, 2026
@cmss13-ci cmss13-ci Bot added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more size/L Denotes a PR that changes 200-799 lines, ignoring generated files. labels Jul 9, 2026
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 12, 2026
@cm13-github

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 12, 2026
@cm13-github

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Venuska1117
Venuska1117 marked this pull request as draft July 12, 2026 15:24
@Venuska1117 Venuska1117 changed the title Defender, Steelcreast and Bulwark no longer keep stance abilities active when stunned/dead and display correct knockdown sprites. Defender, Steelcreast and Bulwark no longer keep fortify and reflective abilities active when stunned/dead and display correct knockdown sprites. Jul 12, 2026
@Venuska1117 Venuska1117 changed the title Defender, Steelcreast and Bulwark no longer keep fortify and reflective abilities active when stunned/dead and display correct knockdown sprites. Defender, Steelcreast and Bulwark no longer keep stances active when stunned/dead and display correct knockdown sprites. Jul 12, 2026
@Venuska1117
Venuska1117 marked this pull request as ready for review July 12, 2026 19:46
@cmss13-ci

cmss13-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci Bot added the Stale beg a maintainer to review your PR label Jul 23, 2026
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 28, 2026
@cm13-github

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cmss13-ci cmss13-ci Bot removed the Stale beg a maintainer to review your PR label Jul 29, 2026
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 30, 2026
@cm13-github

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 2, 2026
@cm13-github

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 3, 2026
@cm13-github

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cmss13-ci

cmss13-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci Bot added the Stale beg a maintainer to review your PR label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more size/L Denotes a PR that changes 200-799 lines, ignoring generated files. Stale beg a maintainer to review your PR

Projects

Status: Awaiting Review

Development

Successfully merging this pull request may close these issues.

Stunned Bulwark Warriors don't have a proper animation. Defender sprite doesn't update when stunned if fortified or crest down

2 participants