Skip to content

[REFACTOR] Moves most of lurker behavior code and vars to respective abilities. - #12628

Open
Venuska1117 wants to merge 6 commits into
cmss13-devs:masterfrom
Venuska1117:nu2-lurker
Open

[REFACTOR] Moves most of lurker behavior code and vars to respective abilities.#12628
Venuska1117 wants to merge 6 commits into
cmss13-devs:masterfrom
Venuska1117:nu2-lurker

Conversation

@Venuska1117

@Venuska1117 Venuska1117 commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Detached from: #12601

About the pull request

Moved vars from behavior to respective abilities, replaced some of TRUE/FALSE vars with traits for easier reference in different files or in future code.

Explain why it's good for the game

Easier to use code in future.

Testing Procedure

Made new code, used invisibility, ability works correctly.
Used assasinate, assasinate works correctly.

Code works as intended.

Changelog

🆑 Venuska1117
refactor: Changed most of lurker ability vars to use traits for easier reference, behaviour vars that are used by specific ability are moved to ability file.
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jul 12, 2026
@Venuska1117 Venuska1117 changed the title Moves most of lurker behavior code and vars to respective abilities, improves code (no balance changes) [Refactor] Moves most of lurker behavior code and vars to respective abilities, improves code. Jul 12, 2026
@cmss13-ci cmss13-ci Bot added Refactor Make the code harder to read size/M Denotes a PR that changes 50-199 lines, ignoring generated files. labels Jul 12, 2026
@Venuska1117 Venuska1117 changed the title [Refactor] Moves most of lurker behavior code and vars to respective abilities, improves code. [REFACTOR] Moves most of lurker behavior code and vars to respective abilities, improves code. Jul 12, 2026
@Venuska1117

Venuska1117 commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

I have text file for pre-changes and current-changes for lurker for better code visibility and easier review, ping me on discord if you are interested in files that can be used on "text compare" website

@Venuska1117 Venuska1117 changed the title [REFACTOR] Moves most of lurker behavior code and vars to respective abilities, improves code. [REFACTOR] Moves most of lurker behavior code and vars to respective abilities. Jul 12, 2026

@fira fira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's AssasSinate, with 4 S

@github-project-automation github-project-automation Bot moved this from Awaiting Review to Changes Requested in Review Backlog Jul 14, 2026
Comment thread code/modules/mob/living/carbon/xenomorph/castes/Lurker.dm
@cmss13-ci

cmss13-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci Bot added the Stale beg a maintainer to review your PR label Jul 23, 2026
fira
fira previously approved these changes Jul 23, 2026
@github-project-automation github-project-automation Bot moved this from Changes Requested to Partially Approved / Mergeable in Review Backlog Jul 23, 2026
@cmss13-ci cmss13-ci Bot closed this Jul 31, 2026
@github-project-automation github-project-automation Bot moved this from Partially Approved / Mergeable to Closed in Review Backlog Jul 31, 2026
@fira fira reopened this Aug 1, 2026
@github-project-automation github-project-automation Bot moved this from Closed to Awaiting Review in Review Backlog Aug 1, 2026
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Aug 1, 2026
@cmss13-ci

cmss13-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci Bot added the Stale beg a maintainer to review your PR label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Make the code harder to read size/M Denotes a PR that changes 50-199 lines, ignoring generated files. Stale beg a maintainer to review your PR

Projects

Status: Awaiting Review

Development

Successfully merging this pull request may close these issues.

4 participants