[REFACTOR] Moves most of lurker behavior code and vars to respective abilities. - #12628
[REFACTOR] Moves most of lurker behavior code and vars to respective abilities.#12628Venuska1117 wants to merge 6 commits into
Conversation
|
I have text file for pre-changes and current-changes for lurker for better code visibility and easier review, ping me on discord if you are interested in files that can be used on "text compare" website |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Detached from: #12601
About the pull request
Moved vars from behavior to respective abilities, replaced some of TRUE/FALSE vars with traits for easier reference in different files or in future code.
Explain why it's good for the game
Easier to use code in future.
Testing Procedure
Made new code, used invisibility, ability works correctly.
Used assasinate, assasinate works correctly.
Code works as intended.
Changelog
🆑 Venuska1117
refactor: Changed most of lurker ability vars to use traits for easier reference, behaviour vars that are used by specific ability are moved to ability file.
/:cl: