Skip to content

Respect mapped touchpad clicks in PlayStation output reports - #131

Merged
hbashton merged 1 commit into
hbashton:mainfrom
meiameiameia:fix/respect-mapped-touchpad-click
Oct 9, 2026
Merged

hbashton merged 1 commit into
hbashton:mainfrom
meiameiameia:fix/respect-mapped-touchpad-click

Conversation

@meiameiameia

Copy link
Copy Markdown
Contributor

Addresses #128.

When a touchpad click is remapped to a keyboard key with click passthrough disabled, the mapper clears OutputTouchButton. The VIIPER DS4 and DualSense packet builders then OR it with the physical TouchButton, reintroducing the original click alongside the remapped key.

Use OutputTouchButton in both packet builders. This preserves deliberate passthrough, mapped controller clicks and macros, including DualSense Edge, while respecting the mapper's suppression of the physical click. No profile format, controller support or VIIPER backend changes.

Validation:

  • Added 23 synthetic cases covering the physical/mapped state matrix, all touchpad modes, explicit passthrough, left/right/upper/multi-touch mappings, key release and controller macros. Each checks DS4, DualSense and Edge output packets.
  • The initial regression subset failed 6 cases before the fix.
  • Release x64 build succeeded; 404 related tests passed in combined local validation, including the separate Bluetooth special-action fix. The patches apply independently to main at 3650240.
  • Tests use disposable in-memory profiles and a recording input handler; no live controller, driver or backend was launched.

Hardware follow-up for someone with DualSense: with emulated DualSense, Controls mode and click passthrough off, map touchpad regions to keys and check that the game receives the selected key without the original click (including the CoD behavior in #128). Repeat over USB and Bluetooth, then enable passthrough and confirm the native click returns. Game/hardware behavior has not been validated locally.

Checked open PRs: #70 also touches ViiperOutDevice.cs, but does not change these click builders. This PR is independent of #129 and #130.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants