Repository navigation
Respect mapped touchpad clicks in PlayStation output reports - #131
Merged
hbashton merged 1 commit intoOct 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #128.
When a touchpad click is remapped to a keyboard key with click passthrough disabled, the mapper clears OutputTouchButton. The VIIPER DS4 and DualSense packet builders then OR it with the physical TouchButton, reintroducing the original click alongside the remapped key.
Use OutputTouchButton in both packet builders. This preserves deliberate passthrough, mapped controller clicks and macros, including DualSense Edge, while respecting the mapper's suppression of the physical click. No profile format, controller support or VIIPER backend changes.
Validation:
Hardware follow-up for someone with DualSense: with emulated DualSense, Controls mode and click passthrough off, map touchpad regions to keys and check that the game receives the selected key without the original click (including the CoD behavior in #128). Repeat over USB and Bluetooth, then enable passthrough and confirm the native click returns. Game/hardware behavior has not been validated locally.
Checked open PRs: #70 also touches ViiperOutDevice.cs, but does not change these click builders. This PR is independent of #129 and #130.