Skip to content

Add python3-robotmem-pip rosdep key#50206

Open
robotmem wants to merge 2 commits intoros:masterfrom
robotmem:add-python3-robotmem-pip
Open

Add python3-robotmem-pip rosdep key#50206
robotmem wants to merge 2 commits intoros:masterfrom
robotmem:add-python3-robotmem-pip

Conversation

@robotmem
Copy link
Copy Markdown
Contributor

@robotmem robotmem commented Mar 11, 2026

Summary

Add rosdep key python3-robotmem-pip for the robotmem Python package.

robotmem is a robot experience memory system that provides persistent cross-episode memory for robot LLMs. It's used as a runtime dependency by robotmem_ros ROS 2 packages.

Details

  • PyPI package: robotmem (v0.1.0)
  • License: Apache-2.0
  • rosdep key: python3-robotmem-pip
  • Install method: pip (all platforms)

Changes

  • rosdep/python.yaml: Added python3-robotmem-pip entry with '*' platform wildcard pointing to pip package robotmem

robotmem is a robot experience memory system for large language models.
Published on PyPI: https://pypi.org/project/robotmem/

This adds a rosdep key so that robotmem_ros ROS 2 packages can
declare robotmem as a pip dependency via exec_depend.
@robotmem robotmem requested a review from a team as a code owner March 11, 2026 12:21
@github-actions github-actions Bot added the rosdep Issue/PR is for a rosdep key label Mar 11, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the Infrastructure General channel on our Zulip server.


For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Installers for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ❌ One or more linter violations were added to YAML files

Comment thread rosdep/python.yaml
'*':
pip:
packages: [robyn]
python3-robotmem-pip:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line does not pass YAML linter checks: wrong ordering of key "python3-robotmem-pip" in mapping

Comment thread rosdep/python.yaml Outdated
ubuntu:
pip:
packages: [zulip]
packages: [zulip] No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line does not pass YAML linter checks: no new line character at the end of file

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@InvincibleRMC
Copy link
Copy Markdown
Contributor

InvincibleRMC commented Mar 17, 2026

@robotmem You would likely need to vendor internally you pip package. The ros buildfarm doesn't support building packages with pip dependencies. We could add this pip package to rosdep but, builds wouldn't work.

@christophebedard
Copy link
Copy Markdown
Member

A rosdep pip key simply gets ignored by the buildfarm, and, since this is Python, it would only be an issue at runtime, i.e., users would need to run rosdep to install the pip package after installing whatever depends on it (e..g, robotmem_ros).

@mjcarroll mjcarroll added the more information needed Maintainers have asked for additional information label Mar 31, 2026
@mjcarroll
Copy link
Copy Markdown
Member

Automated Review for Rosdep Rule

  • Missing required distribution links in PR body: Debian, Ubuntu

Checking Pip Key: python3-robotmem-pip

  • No native package found for python3-robotmem-pip, pip seems appropriate.

@christophebedard christophebedard added rosdep-needs-second-approval rosdep key PR is waiting for a 2nd approval and removed more information needed Maintainers have asked for additional information labels Apr 3, 2026
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the constraints mentioned above, I think this is OK. This needs a 2nd approval now

@github-actions
Copy link
Copy Markdown

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions Bot added the stale Issue/PR hasn't been active in a while and may be closed. label Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rosdep Issue/PR is for a rosdep key rosdep-needs-second-approval rosdep key PR is waiting for a 2nd approval stale Issue/PR hasn't been active in a while and may be closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants