[claude] Fix Mac Catalyst DMG shipping without its web UI - #2694
Conversation
The DMG was built from maccatalyst-arm64/, an intermediate of the multi-RID build that lacks the bundle resources (wwwroot, app icon), so the app opened to "There is no content at". The SDK does merge and sign a complete universal bundle, but SelfContained=true made the .NET SDK give the RID-less outer build the host RID, so it landed in bin/.../osx-arm64/ and looked missing. UseCurrentRuntimeIdentifier=false puts it back in bin/.../net10.0-maccatalyst/ (macios does the same for NativeAOT universal builds), which replaces the hand-rolled lipo merge and re-sign. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Mac Catalyst project disables current runtime identifier selection. The notarization workflow uses the SDK-produced universal app, verifies its signature, checks for ChangesMac Catalyst Universal App
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change is ready for normal build and notarization checks; no actionable packaging risk is established by the available evidence. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit watched the bundles grow, Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
[Claude, autonomous]
The DMG shipped a per-arch intermediate bundle with no
wwwroot, so the app opened to "There is no content at".SelfContained=truewas pushing the SDK's complete, signed universal bundle intobin/.../osx-arm64/; this puts it back where the SDK documents it and ships it instead of the hand-rolled lipo + re-sign.🤖 Generated with Claude Code