Skip to content

[claude] Fix Mac Catalyst DMG shipping without its web UI - #2694

Merged
myieye merged 1 commit into
developfrom
claude/alpha-mac-issues-22afc6
Sep 28, 2026
Merged

myieye merged 1 commit into
developfrom
claude/alpha-mac-issues-22afc6

Conversation

@myieye

@myieye myieye commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

[Claude, autonomous]

The DMG shipped a per-arch intermediate bundle with no wwwroot, so the app opened to "There is no content at". SelfContained=true was pushing the SDK's complete, signed universal bundle into bin/.../osx-arm64/; this puts it back where the SDK documents it and ships it instead of the hand-rolled lipo + re-sign.

🤖 Generated with Claude Code

The DMG was built from maccatalyst-arm64/, an intermediate of the
multi-RID build that lacks the bundle resources (wwwroot, app icon),
so the app opened to "There is no content at".

The SDK does merge and sign a complete universal bundle, but
SelfContained=true made the .NET SDK give the RID-less outer build the
host RID, so it landed in bin/.../osx-arm64/ and looked missing.
UseCurrentRuntimeIdentifier=false puts it back in bin/.../net10.0-maccatalyst/
(macios does the same for NativeAOT universal builds), which replaces
the hand-rolled lipo merge and re-sign.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Sep 25, 2026
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 522b308b-4353-4945-82b1-bac2ac2d54e2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: a1468e93-d431-46c7-955f-6c6881bf506f

📥 Commits

Reviewing files that changed from the base of the PR and between 83c1805 and d966eae.

📒 Files selected for processing (2)
  • .github/workflows/fw-lite.yaml
  • backend/FwLite/FwLiteMaui/FwLiteMaui.csproj

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Mac Catalyst project disables current runtime identifier selection. The notarization workflow uses the SDK-produced universal app, verifies its signature, checks for Contents/Resources/wwwroot/index.html, and retains the existing architecture check, DMG packaging, and notarization.

Changes

Mac Catalyst Universal App

Layer / File(s) Summary
Universal app build and notarization
.github/workflows/fw-lite.yaml, backend/FwLite/FwLiteMaui/FwLiteMaui.csproj
The project disables UseCurrentRuntimeIdentifier for Mac Catalyst. The workflow uses the SDK-produced universal app, verifies its signature, and fails if Contents/Resources/wwwroot/index.html is missing. The architecture check, DMG packaging, and notarization remain.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: hahn-kev

Merge Risk: ⚪ Minimal · up to d966e

The change is ready for normal build and notarization checks; no actionable packaging risk is established by the available evidence.

Architecture Summary

Architecture risk: 🔵 Low · up to d966e

The change affects 1 system.

Changed systems: backend

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — backend (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in backend/FwLite/FwLiteMaui/FwLiteMaui.csproj: For Mac Catalyst targets, the project now disables UseCurrentRuntimeIdentifier; no prior setting existed.
  • observed — Modified behavior in .github/workflows/fw-lite.yaml: The notarization step removes manual per-architecture bundle validation, copying, Mach-O merging, and nested/app re-signing. It instead selects the SDK-produced universal app, verifies its signature, and exits with an error if its wwwroot/index.html is absent.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description directly explains the Mac Catalyst DMG packaging fix, the missing wwwroot, and the replacement of the manual universal-bundle handling.
Title check ✅ Passed The title clearly identifies the Mac Catalyst DMG fix and the missing web UI, which matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit watched the bundles grow,
One universal app, ready to go.
Its signature checked, its web page in sight,
Then off to the DMG, sealed up tight.
The rabbit thumped softly: “Build done right!”

Comment @coderabbitai help to get the list of available commands.

@argos-ci

argos-ci Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Sep 25, 2026, 11:38 AM
e2e (Inspect) ✅ No changes detected - Sep 25, 2026, 11:46 AM

@myieye
myieye merged commit d219ca7 into develop Sep 28, 2026
39 of 41 checks passed
@myieye
myieye deleted the claude/alpha-mac-issues-22afc6 branch September 28, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants