Skip to content

chore: ignore generated files in the prettier check - #3161

Closed
xyrolle wants to merge 1 commit into
sveltejs:masterfrom
xyrolle:chore/prettierignore-generated
Closed

xyrolle wants to merge 1 commit into
sveltejs:masterfrom
xyrolle:chore/prettierignore-generated

Conversation

@xyrolle

@xyrolle xyrolle commented Oct 22, 2026

Copy link
Copy Markdown

pnpm lint fails locally once the repo has been bootstrapped and tested. It checks:

  • the grammar files build:grammar writes to packages/svelte-vscode/syntaxes/;
  • the .svelte-check caches the svelte-check sanity tests leave in their fixtures.

Both are gitignored, but in nested .gitignore files, and root pnpm lint doesn't read those. CI's lint job runs on a fresh checkout, so it never sees them. This adds them to .prettierignore.

Test plan: after pnpm bootstrap and pnpm test, pnpm lint reported 25 files on master and passes with this change.

@changeset-bot

changeset-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: efa9d9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant