Repository navigation
Conversation
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeferredRemovalclears the output array and both lookup maps before removing feedback and disconnecting. If either operation throws, the attached slot loses its registration and cannot be retried through the normal lookup. Bulk shutdown also clears the array before disconnecting and can leave stale maps after a partial failure.Keep the exact registration until teardown returns successfully, then detach the slot and publish its removal. During bulk shutdown, remove each successful output from both maps immediately so a failed later disconnect leaves only the remaining output registered for retry.
Synthetic regression tests cover feedback/disconnect exceptions for bound and unbound outputs, another output connecting after a failure, retries, repeated removal, event publication, partial shutdown and permanent slot preferences. No virtual device or driver is created by these tests.
Validation on Windows, .NET SDK 8.0.425, Release x64:
OutputSlotRemovalTestspassed as part of the combined validation run.36502408cbba17fd20d84e6b258f2258714a39c6.This covers failures propagated by the output implementation. It does not establish physical removal or address errors swallowed by a backend. Hardware validation has not been performed.
Related work: #70 changes these disconnect call sites to detach native PnP ownership. Its current patch does not defer manager registration removal; these call sites may need reconciliation if that PR lands first.
Focused check: